[Property Wrappers] Always check actor isolation and initializer effects in PropertyWrapperInitializerInfoRequest.
#37627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lizer effects in PropertyWrapperInitializerInfoRequest. Now that property wrapper initializer synthesis and checking is separated from creating the auxiliary variables, checking actor isolation from PropertyWrapperInitializerInfoRequest will not create a circular dependency. This also fixes a local property wrapper crash due to effects checking never being done on synthesized default wrapper initializers.
wrapper default initializers.
…nerator function for default-initialized local and static wrapped properties.
|
@swift-ci please smoke test |
|
@swift-ci please test source compatibility |
slavapestov
approved these changes
May 25, 2021
|
There's one source compatibility failure that's unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that property wrapper initializer synthesis and checking is separated from creating the auxiliary variables, checking actor isolation from
PropertyWrapperInitializerInfoRequestwill not create a circular dependency.This also fixes 2 bugs:
I believe this still worked for properties because the auxiliary variables are actually inserted into the AST.
Resolves: rdar://74616133